Add Cloudflare turn servers #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Brutus5000
commented
Nov 27, 2024
•
Brutus5000
commented
Brutus5000
force-pushed
the
feature/cloudflare-turn
branch
from
3118207 to
38b6b2a
Compare
Brutus5000
force-pushed
the
feature/cloudflare-turn
branch
from
38b6b2a to
d0e3e65
Compare
Sheikah45
approved these changes
Nov 28, 2024
| import jakarta.ws.rs.core.HttpHeaders | ||
|
|
||
| @Priority(Priorities.AUTHENTICATION) | ||
| class ApiKeyAuthenticationRequestFilter(turnApiKey: String) : ClientRequestFilter { |
There was a problem hiding this comment.
I am a little surprised we have to write our own filter for this, but seems like that is the way to do it.
|
|
||
| @Singleton | ||
| class CloudflareSessionHandler( | ||
| cloudflareProperties: CloudflareProperties, |
There was a problem hiding this comment.
val is only required if I access the variable after initialization. This is not the case here, this it is not required
Comment on lines
+42
to
+44
| // A sample response looks like "stun:fr-turn1.xirsys.com" | ||
| // The java URI class fails to read host and port due to the missing // after the : | ||
| // Thus we "normalize" the uri, even though it is technically valid |
There was a problem hiding this comment.
This is true for cloudflare as well?
There was a problem hiding this comment.
Yes. Surprisingly, they also have the exact same response structure for credential and username. Maybe it is part of the RFC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.